Cryptomatte : Rename __manifestScene plug
#5927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murraystevenson
force-pushed
the
cryptomatteManifestScenePlug
branch
from
40a19f5
to
8486923
Compare
johnhaddon
reviewed
Jun 28, 2024
There was a problem hiding this comment.
Technically this is a breaking change, but then this is/was a private plug...
Since it was private, I don't see it as a breaking change. In the worst case we can add a compatibility shim if anyone runs into trouble, but I don't think we should right now.
Having the plug be public seems pretty reasonable anyway - could be useful. Worth a mention in Changes.md?
| """, | ||
|
|
||
| "plugValueWidget:type", None, | ||
| "nodeGadget:type", None, |
There was a problem hiding this comment.
I think this would need to be "nodule:type", but since the nodule isn't showing up, I presume it's not actually necessary.
murraystevenson
force-pushed
the
cryptomatteManifestScenePlug
branch
from
8486923
to
fd67c3b
Compare
This becomes necessary now that we make the Hierarchy View ignore private plugs. `__manifestScene` will now be ignored, resulting in the Hierarchy View no longer displaying the Cryptomatte manifest, so we rename the plug to `manifestScene`.
murraystevenson
force-pushed
the
cryptomatteManifestScenePlug
branch
from
fd67c3b
to
ae8bfe3
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This becomes necessary now that we make the Hierarchy View ignore private plugs in #5924.
__manifestScenewill now be ignored, resulting in the Hierarchy View no longer displaying the Cryptomatte manifest, so we rename the plug tomanifestSceneand hide both its nodeGadget and plugValueWidget.Technically this is a breaking change, but then this is/was a private plug...