Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PathListingWidget : Avoid blocking UI in setPath( rootPath ) #5948

Merged

Commits on Jul 9, 2024

  1. PathListingWidget : Avoid blocking UI in setPath( rootPath )

    The root path is the only path that we ever display in fundamental UIs like the HierarchyView and RenderPassEditor. In this case we were needlessly invoking `Path.isLeaf()` and `Path.isValid()` on the UI thread, causing ScenePath and RenderPassPath to trigger arbitrary computation that could block the UI until complete. By taking an early-out for the root path can completely avoid that, with all the remaining work all happening in a BackgroundTask.
    johnhaddon committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f8add5e View commit details
    Browse the repository at this point in the history