Set PXR_USD_WINDOWS_DLL_PATH on Windows
#5949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
reviewed
Jul 9, 2024
bin/gaffer.cmd
Outdated
| @@ -19,6 +19,9 @@ call :prependToPath "%GAFFER_ROOT%\ops" IECORE_OP_PATHS | |||
|
|
|||
| call :prependToPath "%GAFFER_ROOT%\resources\IECoreUSD" PXR_PLUGINPATH_NAME | |||
| call :prependToPath "%GAFFER_ROOT%\materialX" PXR_MTLX_STDLIB_SEARCH_PATHS | |||
| if "%PXR_USD_WINDOWS_DLL_PATH%" EQU "" ( | |||
| set PXR_USD_WINDOWS_DLL_PATH=%GAFFER_ROOT%/lib | |||
There was a problem hiding this comment.
One question about this - we already call add_dll_directory() for GAFFER_ROOT/lib, right? So is this about stopping USD using PATH more than it is about getting USD to use GAFFER_ROOT/lib? If so, would it be more accurate to set the env -var to ""?
There was a problem hiding this comment.
Yes, I guess this is more about preventing PATH entries from getting used since we're already setting the right binary path. I amended the commit and the commit wording and changelog entry to reflect that.
I also verified this works by pointing my PATH at a conflicting USD installation, checking that it fails without this patch and that the patch fixes it.
If this variable is set, USD will not add the entries from `PATH` to the Python binary search paths. We set it to an empty string because the `Gaffer` module adds the proper binary path and our intention here is only to prevent USD from adding `PATH` entries.
johnhaddon
force-pushed
the
usdWindowsPath
branch
from
de32cce
to
b4c7462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the
PXR_USD_WINDOWS_DLL_PATHenvironment variable if it has not been set already. That variable helps USD setup the Python binary search paths, making sure it finds for our USD installation. Some users were finding that USD was attempting to load binaries from other installations they have on their system which was causing errors.Checklist