Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnnotationsGadget binding : Fix GIL management bug #5951

Merged
merged 1 commit into from
Jul 10, 2024
Merged

AnnotationsGadget binding : Fix GIL management bug #5951

merged 1 commit into from
Jul 10, 2024

Commits on Jul 10, 2024

  1. AnnotationsGadget binding : Fix GIL management bug 

    The `annotationText()` method may call `BackgroundTask::cancelAndWait()`, in which case the background task might require the GIL before the cancellation can complete. The lack of GIL management was causing hangs in the unit tests, but is unlikely to have caused any real-world problems, because `annotationText()` is only intended for use in the tests.
    @johnhaddon
    johnhaddon committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    bf74d1c View commit details
    Browse the repository at this point in the history