ColorChooser : TMI Sliders
#5962
Conversation
There was a problem hiding this comment.
Thanks Eric - seems to work well. I don't have much experience of using TMI sliders so I was surprised at how easy it is to end up with negative RGB while modifying TMI, but I see that a certain other package doesn't protect against that, so maybe folks will be savvy to that already?
|
Thanks John! I addressed the comments, and stuck my head in the sand for a bit longer on the column vs. grid-only layout question, if that's ok. It is odd how some components go outside the 0-1 range fairly easily. I'm not sure what a better behavior would be, the other DCCs I've tested allow it, as you noted, so I guess artists just need to be aware of it. Maybe we could consider some kind of warning indicator when a channel goes outside the 0-1 range? Ready for a new look! |
Thanks! I've squashed the fixups in preparation for a merge, and also changed the target to
Totally fine.
I've pushed one further commit which explores this idea using the existing "out of range triangle" that the sliders have. It means loosening the restrictions on the slider interaction slightly, but I think it's a net win, and I think this subtle indicator is probably enough compared to anything more drastic, especially if folks are used to the gotchas elsewhere. See what you think... |
That looks good to me, nice to keep it consistent with how it's been shown already. I dropped the temporary commit in anticipation of merging. ( I have it locally for later or if you want me to add it back in for more testing). And yes, merging this to 1.4 was my intention, thanks for catching that. |
|
Looks like the previous commits have a dependency on the temp commit. |
This was broken slightly in GafferHQ#5902 when we introduced channel name labels. The text width varies somewhat, causing the numeric widget and sliders to be imperfectly aligned.
We don't really want to allow these, but they can occur naturally in one component while editing values in another. By accommodating that within the slider `hardMin`, we get a nice "out of range" triangle to alert us when we've gone negative, whereas before the slider clamped to zero and gave us a misleading value. For consistency, we now also allow negative values to be entered directly in the numeric widgets - if you can get into that state using a slider or numeric widget for another compoment, why preclude it in the field itself?
|
It was attempting to set the slider value for a slider that didn't exist. Fixed and squashed into f8f0945. Should be good to go now. |
This adds three new color sliders to the
ColorChooser: temperature, magenta and intensity. The conversion between TMI and RGB is based on the formulas from https://www.comp-fu.com/2012/05/tmi-color-temperature-correction/ and modified to account for the different between grading an existing color and generating one.This is the first in a few PRs adding features to
ColorChooser. Our intention is to not expose the changes until a final PR to incorporate all the changes, because the layout in particular is likely to evolve as additional features are added. The last commit is meant as a testing commit to test this PR. We will drop it before actually merging.Checklist