HistoryWindow : Add icon for CreateIfMissing tweak mode
#5965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
reviewed
Jul 18, 2024
| @@ -63,6 +63,7 @@ def cellData( self, path, canceller = None ) : | |||
| Gaffer.TweakPlug.Mode.Multiply : "multiplySmall.png", | |||
| Gaffer.TweakPlug.Mode.Remove : "removeSmall.png", | |||
| Gaffer.TweakPlug.Mode.Create : "createSmall.png", | |||
| Gaffer.TweakPlug.Mode.CreateIfMissing : "createIfMissingSmall.png", | |||
There was a problem hiding this comment.
Not something to do now, but maybe worth bearing in mind for future refactoring. I think it would be much better if these icons were named to reflect that they are for tweak modes - tweakModeReplace.png for example. I had a hard time tracking them down the other day because they are named so generically. If they were named consistently then we wouldn't need this map either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the icon for the
CreateIfMissingtweak mode, currently an error icon would be displayed in the History Window for entries using that mode.