Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HistoryWindow : Add icon for CreateIfMissing tweak mode #5965

Merged
merged 1 commit into from
Jul 18, 2024
Merged

HistoryWindow : Add icon for CreateIfMissing tweak mode #5965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
1.3.16.x (relative to 1.3.16.6)
========

Fixes
-----

- LightEditor, RenderPassEditor : Added missing icon representing use of the `CreateIfMissing` tweak mode in the history window.

1.3.16.6 (relative to 1.3.16.5)
========
Expand Down
1 change: 1 addition & 0 deletions python/GafferSceneUI/_HistoryWindow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ def cellData( self, path, canceller = None ) :
Gaffer.TweakPlug.Mode.Multiply : "multiplySmall.png",
Gaffer.TweakPlug.Mode.Remove : "removeSmall.png",
Gaffer.TweakPlug.Mode.Create : "createSmall.png",
Gaffer.TweakPlug.Mode.CreateIfMissing : "createIfMissingSmall.png",
Copy link
Member

@johnhaddon johnhaddon Jul 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something to do now, but maybe worth bearing in mind for future refactoring. I think it would be much better if these icons were named to reflect that they are for tweak modes - tweakModeReplace.png for example. I had a hard time tracking them down the other day because they are named so generically. If they were named consistently then we wouldn't need this map either.

Gaffer.TweakPlug.Mode.Min : "lessThanSmall.png",
Gaffer.TweakPlug.Mode.Max : "greaterThanSmall.png",
Gaffer.TweakPlug.Mode.ListAppend : "listAppendSmall.png",
Expand Down
1 change: 1 addition & 0 deletions resources/graphics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,7 @@
"multiplySmall",
"replaceSmall",
"createSmall",
"createIfMissingSmall",
"lessThanSmall",
"greaterThanSmall",
"listAppendSmall",
Expand Down
14 changes: 14 additions & 0 deletions resources/graphics.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading