Inspector : fallbackValue improvements #5968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
reviewed
Jul 23, 2024
| @@ -4,7 +4,9 @@ | |||
| Improvements | |||
| ------------ | |||
|
|
|||
| - LightEditor : Values of inherited attributes are now displayed in the Light Editor. These are presented as dimmed "fallback" values. | |||
| - LightEditor : | |||
| - Values of inherited attributes are now displayed in the Light Editor. These are presented as dimmed "fallback" values. Values are inherited from an ancestor of the inspected location or from attributes created in the scene globals. | |||
There was a problem hiding this comment.
Might be worth mentioning the tooltip here.
There was a problem hiding this comment.
Good idea! I've mentioned the tooltip in 8c5812a.
|
Thanks for the feedback! Everything should be addressed inline. |
johnhaddon
reviewed
Jul 24, 2024
When no inherited attribute exists, fall back to the equivalent attribute in the scene globals, with "defaultValue" metadata used to provide the default value of non-existent attributes - equivalent to how we handle default values of non-existent options in the OptionInspector.
This is not a complete registration of the attributes creatable by OpenGLAttributes, but the subset of attributes registered by default in the Light Editor.
As fallback values could originate from various sources, we provide an output `&description` parameter to `fallbackValue()` to provide a user-facing description of the source of the fallback.
We can now remove the inheritance lookup from MuteColumn and SetMembership column as the inspectors now provide this information via the fallbackDescription.
This is not a complete registration of the attributes creatable by StandardAttributes, but the subset of attributes registered by default in the Light Editor.
With `defaultValue` metadata registered for the `light:mute` attribute, InspectorColumn can now consistently include the toggle info in the tooltip so we no longer require this additional handling.
murraystevenson
force-pushed
the
inspectorFallbackDescription
branch
from
8c5812a
to
de9ac47
Compare
|
Thanks Murray! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses some of the todos discussed recently in #5964. It made sense to tackle them now as further simplifying the Light Editor's
MuteColumnandSetMembershipColumnmakes the upcoming InspectorColumn refactor a little more straightforward, plus we gain some user-facing improvements out of these changes.The AttributeInspector now supports global attributes as fallback values when no inherited attribute is found, with a further fallback to
defaultValuemetadata registered toattribute:{attributeName}in order to display default values for non-existent attributes. This metadata follows theoption:{optionName}convention already established in the OptionInspector for options and their default values.Inspector::fallbackValuenow has an outputstring &descriptionparameter which can be used to describe to the user the source of the fallback value, accessible viaInspector::Result::fallbackDescription().These improvements allow us to simplify
MuteColumnandSetMembershipColumndown to configuring icons and overridingCellData::valueso only the icon is displayed. We're fairly close now to removing them entirely...