Arnold Metadata : Add openpbr_surface
#5982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arnold warns if a `.mtd` file references nodes that don't exist, which makes managing metadata for use in multiple Arnold versions a bit of a pain. We were dealing with this by filtering the metadata per-major-version during installation, but that doesn't help when Arnold introduces a new node - such as `openpbr_surface` - within a minor release. So now we just suppress the warnings, and have a much simplified installation process.
When a custom label is used, it often omits the "Page" information which is provided by the layout in the NodeEditor. This isn't good in the GraphEditor, so there we fall back to a label generated from the full parameter name.
I've given pretty much everything a custom label that omits the Base/Specular/Coat etc prefix which is shown in the layout sections anyway. This was necessary due to an increased prevalence of long names compared to `standard_surface`, such as `transmission_dispersion_abbe_number`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a little bit of hoop-jumping to suppress warnings in older Arnold versions where the shader doesn't exist.