Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer config : Add diagnostic shading mode for usd:purpose #5983

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

johnhaddon
Copy link
Member

Some open questions here :

  1. This suffers from a problem I've just discovered that all the diagnostic modes have : they are overridden by any Cs primitive variables on an object. It feels like we should fix this, but I'm not sure where - the easiest would be to use a different shader than Constant. Should this be a new shader, in which case what should it be called or should it be private ? Or should we use the existing FacingRatio?
  2. Should this automatically turn all includedPurposes on so you are visualising, or is that surprising or at the very least a performance hazard.
  3. What should the colours be?

@johnhaddon johnhaddon self-assigned this Aug 1, 2024
@murraystevenson
Copy link
Contributor

FacingRatio would get my vote, individual objects are more easily discernible than with a Constant (or a new private ConstantButIgnoresCs) on everything. An interior scene like the ALab would be much easier to navigate with this diagnostic mode enabled if it were using FacingRatio.

I think this should probably not enable all includedPurposes. As you say, that would seem surprising at best and a performance hazard at worst.

I don't mind the colours you've picked, though an alternate could be something with a bit more of an associative quality, like "Red for render, green for guide, blue for p(b)roxy..." 🤷

@johnhaddon
Copy link
Member Author

FacingRatio would get my vote

Cool - I've pushed an update that uses that.

Copy link
Contributor

@murraystevenson murraystevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@johnhaddon johnhaddon merged commit 1ba35c0 into GafferHQ:1.4_maintenance Aug 7, 2024
6 checks passed
@johnhaddon johnhaddon deleted the purposeVisualiser branch August 7, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants