Small Catalogue improvements #5991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
johnhaddon
commented
Aug 5, 2024
johnhaddon
commented
- Allow image properties section (name and description) to be resized.
- Fix bug that allowed read-only catalogues to be edited.
- Fix bug when first image added and last image removed.
murraystevenson
approved these changes
Aug 6, 2024
Doing it in `_updateFromValues()` means we don't update at the right times.
These need to track changes to node metadata too. Also, fix editability of `NameWidget( graphComponent = None )`.
The description field was growing a little large for some folks' taste. I did try limiting the description field to a fixed number of lines, but I'm concerned that some other folks might be using large descriptions (lots of different notes on settings perhaps?), so I think providing explicit control is probably better.
In this case, the `index` plug doesn't change value, but whether or not it maps to an actual image does change. And we use that mapping in `_updateFromValues()`, so the first image added wasn't connected to the `__descriptionWidget` and `__nameWidget`, and the last image removed wasn't disconnected.
johnhaddon
force-pushed
the
catalogueDescriptionHeight
branch
from
88eea08
to
a34d35a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.