SpreadsheetUI : Use ContextTracker #5992
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us highlight the currently active row like so :
There is ample room for bikeshedding on the presentation, and opinions are welcome, but I am pretty sold on "context yellow" as a way of tying together all the upcoming context-aware features and linking with the existing colour for the current-frame indicator. @tomc-cinesite had some concerns that it could be confused for a warning, but in context I think it works pretty well, and used sparingly yellow works well to draw the eye without overwhelming. I don't know what other colour we'd use.
Tom also suggested a few alternative presentations, which I've tried out below...
Adding an "overline" to the underline
To avoid any ambiguity about what the underline is associated with. I don't mind this one, but I'm not sure the underlining is too ambiguous, especially once you've seen it update in context once or twice.
Using background colour
I strongly dislike this on two counts :
Using left/right lines
I find this much harder to read than any other presentation. Note that we do need to highlight the left/right of every cell rather than just the row ends, because disabled cells don't get highlighting.