SceneAlgo : Fix history() performance regression #5996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
force-pushed
the
historyRegressionFix
branch
from
eb20e24
to
0425ce9
Compare
This test takes the best part of 10 seconds per run, and models problems we saw in two separate production environments (not using Loops there, but just a series of manually made diamond connections).
johnhaddon
force-pushed
the
historyRegressionFix
branch
from
0425ce9
to
06f307a
Compare
This gives us the following pleasing performance improvement : ``` testHistoryDiamondPerformance (GafferSceneTest.SceneAlgoTest.SceneAlgoTest) : was 9.11s now 0.00s (100% reduction) ``` As noted in the comment, this does mean that we're now returning a reduced history, but we don't anticipate this being a problem in practice. Clients such as `attributeHistory()` aim to whittle the graph down to a single path relevant to a particular attribute, and our HistoryWindow only shows a single linear history anyway. The histories we're returning now are a closer match for the ones we returned prior to #4568, while retaining the main benefit of that PR - the evaluations of thing we're not trying to track are still pulled from the cache if possible. Fixes #5199
johnhaddon
force-pushed
the
historyRegressionFix
branch
from
06f307a
to
0fa9c08
Compare
|
Ready for review. |
|
These changes all look good me. Murray also asked me to evaluate the possible risks from doing a 1.4 release including this ... that I feel a bit less qualified to say. John's comment is "this does mean that we're now returning a reduced history, but we don't anticipate this being a problem in practice", which seems accurate to me. I also don't entirely understand the impact of the fix to ValuePlug where it was previously passing the wrong plug to Overall, it definitely seems like an improvement, and it seems highly unlikely that anyone is going to notice any changed behaviour other than the speedup, but hard to guarantee that no one will notice the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #5995, this time with the right permissions to build GafferArnold.