ListContainer alignment #5997
Merged
ListContainer alignment #5997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`QBoxLayout` wraps child widgets in a `QWidgetItem`. `QWidgetItem.maximumSize()` returns `QLAYOUTSIZE_MAX` if the item has non-default alignment, resulting in unnecessary expansion into all available space. By resetting the alignment to default, we can get the real size the widget needs. Changing alignment this way does not have side effects. See `QLayout::alignmentRect()` source for a similar solution to this problem.
ericmehl
force-pushed
the
listContainerAlignment
branch
from
f600f3e
to
4d17877
Compare
|
Thanks Eric! Mergity merged... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the excessive sizing of
ListContainerswhen a child widget has non-default alignment. So far I've only seen one widget that now has incorrect placement, the annotations button in the Graph Editor, which is fixed in this PR. If anyone spots others, I can fix those up as well.Checklist