Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorChooser : Hollow circle indicator #6097

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ericmehl
Copy link
Collaborator

This changes the indicator for the color field and sliders to a white circle, with an inner and outer black stroke. The previous indicator was a solid blue circle, which covered the exact value. I tried a white circle with just an outer black stroke, but it felt like it read a little less clearly in some areas of grayscale, but light and dark.

I'm happy for suggestions on a better API for setting the colors and shapes of the indicator in the second commit. I tried using the hollow circle for all sliders, which currently means the spline slider. It was less visible and it felt less inviting to click and drag on than when used in the color sliders.

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Gaffer project's prevailing coding style and conventions.

@ericmehl
Copy link
Collaborator Author

Based on an offline conversation, I reworked the original commits. Instead of adding more protected methods to override, I duplicated the relevant code for drawing the value from GafferUI.Slider into the color chooser sliders. I also changed the indicator to be a black circle with a white circle inside it (both unfilled).

Ready for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant