ColorChooser : Hollow circle indicator #6097
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the indicator for the color field and sliders to a white circle, with an inner and outer black stroke. The previous indicator was a solid blue circle, which covered the exact value. I tried a white circle with just an outer black stroke, but it felt like it read a little less clearly in some areas of grayscale, but light and dark.
I'm happy for suggestions on a better API for setting the colors and shapes of the indicator in the second commit. I tried using the hollow circle for all sliders, which currently means the spline slider. It was less visible and it felt less inviting to click and drag on than when used in the color sliders.
Checklist