Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisualiserTool : Fix OpenGL buffer creation #6189

Open
wants to merge 1 commit into
base: 1.5_maintenance
Choose a base branch
from
Open

VisualiserTool : Fix OpenGL buffer creation #6189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
1.5.x.x (relative to 1.5.2.0)
=======

Fixes
-----

- VisualiserTool : Fix error when trying to visualise data unsupported data.

1.5.2.0 (relative to 1.5.1.0)
=======
Expand Down
12 changes: 6 additions & 6 deletions src/GafferSceneUI/VisualiserTool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,12 +413,6 @@ class VisualiserGadget : public Gadget
continue;
}

IECoreGL::ConstBufferPtr vBuffer = meshGL->getVertexBuffer( name );
if( !vBuffer )
{
continue;
}

ConstDataPtr vData = vIt->second.data;
GLsizei stride = 0;
GLenum type = GL_FLOAT;
Expand Down Expand Up @@ -452,6 +446,12 @@ class VisualiserGadget : public Gadget
continue;
}

IECoreGL::ConstBufferPtr vBuffer = meshGL->getVertexBuffer( name );
if( !vBuffer )
{
continue;
}

// Get the object to world transform

M44f o2w;
Expand Down