Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new plug to the
VisualiserTool
for the mode of visualisation. Right now we're still only displaying color visualisation, but other types will be coming shortly. The current modes are :Color (Type Range)
. In the future this will change the way various data such as vectors and integers are displayed. I'm including it now as I expect it to be the default in the future and including it now prevents a change in default behavior whenAuto
becomes more meaningful.[-1, 1]
to[0, 1]
.valueMin
andvalueMax
plugs and values are remapped from[valueMin, valueMax]
to[0, 1]
.I considered naming "Color (Type Range)" as "Color (Auto Range)", but went with "Type" because we briefly talked about a mode where we look at the min and max value of the data and use that for the range. That seems more "Auto"-like to me so I figured I'd try not to preclude that future use.
Depends on #6181.
Checklist