Address review comment

Signed-off-by: Gagan Juneja <[email protected]>
Gaganjuneja · Sep 6, 2023 · edf60a3 · edf60a3
1 parent 65cb23b
commit edf60a3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/test/telemetry/src/main/java/org/opensearch/test/telemetry/tracing/MockTracingTelemetry.java b/test/telemetry/src/main/java/org/opensearch/test/telemetry/tracing/MockTracingTelemetry.java
@@ -12,11 +12,7 @@
 import org.opensearch.telemetry.tracing.TracingContextPropagator;
 import org.opensearch.telemetry.tracing.TracingTelemetry;
 import org.opensearch.telemetry.tracing.attributes.Attributes;
-import org.opensearch.test.telemetry.tracing.validators.AllSpansAreEndedProperly;
-import org.opensearch.test.telemetry.tracing.validators.AllSpansHaveUniqueId;
 
-import java.util.Arrays;
-import java.util.List;
 import java.util.concurrent.atomic.AtomicBoolean;
 
 /**

diff --git a/...lemetry/src/main/java/org/opensearch/test/telemetry/tracing/StrictCheckSpanProcessor.java b/...lemetry/src/main/java/org/opensearch/test/telemetry/tracing/StrictCheckSpanProcessor.java
@@ -9,8 +9,11 @@
 package org.opensearch.test.telemetry.tracing;
 
 import org.opensearch.telemetry.tracing.Span;
+import org.opensearch.test.telemetry.tracing.validators.AllSpansAreEndedProperly;
+import org.opensearch.test.telemetry.tracing.validators.AllSpansHaveUniqueId;
 
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.List;
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
@@ -66,7 +69,7 @@ private MockSpanData toMockSpanData(Span span) {
      * Ensures the strict check succeeds for all the spans.
      */
     public static void validateTracingStateOnShutdown() {
-        List<MockSpanData> spanData = new ArrayList(spanMap.values());
+        List<MockSpanData> spanData = new ArrayList<>(spanMap.values());
         if (spanData.size() != 0) {
             TelemetryValidators validators = new TelemetryValidators(
                 Arrays.asList(new AllSpansAreEndedProperly(), new AllSpansHaveUniqueId())