feat: Allow customized Page and TopBar titles (argoproj#164) (argopro…

…j#165) Signed-off-by: Keith Chong <[email protected]>
Gaic4o · Dec 1, 2021 · 49f2577 · 49f2577
1 parent 8152ba7
commit 49f2577
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/src/components/page/page.tsx b/src/components/page/page.tsx
@@ -12,6 +12,8 @@ require('./page.scss');
 interface PageProps extends React.Props<any> {
     title: string;
     toolbar?: Toolbar | Observable<Toolbar>;
+    topBarTitle?: string;
+    useTitleOnly?: boolean;
 }
 
 export interface PageContextProps {
@@ -32,7 +34,7 @@ export const Page = (props: PageProps) => {
                         <PageContext.Consumer>
                             {(ctx) => {
                                 let titleParts = [ctx.title];
-                                if (toolbar && toolbar.breadcrumbs && toolbar.breadcrumbs.length > 0) {
+                                if (!props.useTitleOnly && toolbar && toolbar.breadcrumbs && toolbar.breadcrumbs.length > 0) {
                                     titleParts = [toolbar.breadcrumbs.map((item) => item.title).reverse().join(' / ')].concat(titleParts);
                                 } else if (props.title) {
                                     titleParts = [props.title].concat(titleParts);
@@ -45,7 +47,7 @@ export const Page = (props: PageProps) => {
                             }}
                         </PageContext.Consumer>
                         <div className='page__top-bar'>
-                            <TopBar title={props.title} toolbar={toolbar}/>
+                            <TopBar title={props.topBarTitle ? props.topBarTitle : props.title} toolbar={toolbar}/>
                         </div>
                     </React.Fragment>
                 )}

diff --git a/stories/page.tsx b/stories/page.tsx
@@ -124,4 +124,18 @@ storiesOf('Page', module)
                 </Route>
             </Router>
         );
-    });
+    }).add('custom top bar title', () => (
+        <Router history={history}>
+            <Route path={location.pathname}>
+                <Layout navItems={navItems}>
+                    <Page title='helmet title' topBarTitle='Top Bar Title' toolbar={{ breadcrumbs: [{title: 'Apps ' , path: '/applications'}, {title: 'app name'}] }}>
+                        <div style={{padding: '1em'}}>
+                            <div className='white-box'>
+                                Test
+                            </div>
+                        </div>
+                    </Page>
+                </Layout>
+            </Route>
+        </Router>
+    ));