Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marker button for drivers #61

Open
Emma03L opened this issue Oct 28, 2024 · 13 comments · May be fixed by #74
Open

Add marker button for drivers #61

Emma03L opened this issue Oct 28, 2024 · 13 comments · May be fixed by #74
Labels
enhancement New feature or request

Comments

@Emma03L
Copy link
Collaborator

Emma03L commented Oct 28, 2024

Add option for the drivers to log timestamps and robot pose mid-match in order to mark problems.

@Emma03L Emma03L added the enhancement New feature or request label Oct 28, 2024
@rakrakon
Copy link
Contributor

@katzuv @Emma03L I'm a little confused on how do we want to implement this. Could one of you clear it up?

@katzuv
Copy link
Member

katzuv commented Nov 11, 2024

There's a WPILib logging function which can be used. Find it

Hint (only if you need it!) The function is mentioned in the 2025 suggestions page.

@Emma03L
Copy link
Collaborator Author

Emma03L commented Nov 11, 2024

I assume you're talking about DataLogManager.log() and that was my plan But I also wanted a way for it to show up on the timeline in advantage scope and I'm not sure it can do that. If it can't we can log two things with the same button.
We could even have separate buttons that log different messages for different kinds of problems, though I'm not sure if it will be comfortable for the drivers.

@katzuv
Copy link
Member

katzuv commented Nov 11, 2024

You can see the log in the console tab, maybe as a discrete value in the line graph. You can also a boolean entry. But I think logging a message is the best way, it can be also color highlighted in the console tab.

@rakrakon
Copy link
Contributor

rakrakon commented Nov 19, 2024

I tested the code for the alerts, but you can't view the alerts in AD because for some reason they don't show up in the smartDashboard. I also tried to put just a random number in the smartDashboard but i still can't see it. I think this is a bug in the beta.
Strangely enough the autoChooser does work properly.
@katzuv what do you think?

@katzuv
Copy link
Member

katzuv commented Nov 19, 2024

I'd like to see the code but I think that the base branch in the PR is incorrect, too much diff
#74 (comment)

@katzuv katzuv linked a pull request Nov 19, 2024 that will close this issue
@katzuv
Copy link
Member

katzuv commented Nov 19, 2024

Also, note you can use OutlineViewer to see entries logged to NetworkTables, if that helps.
https://docs.wpilib.org/en/stable/docs/software/wpilib-tools/outlineviewer/index.html

@rakrakon
Copy link
Contributor

rakrakon commented Nov 20, 2024

I changed the base branch. Still doesn't show up in smartDashboard, I checked with outline viewer. @katzuv

@katzuv
Copy link
Member

katzuv commented Nov 22, 2024

You should be able to see the logs in the "messages" field:
Image
https://docs.advantagescope.org/tab-reference/console

@rakrakon
Copy link
Contributor

rakrakon commented Nov 22, 2024

I am seeing the DataLogManager.log, What i can't see is the alerts.

@katzuv
Copy link
Member

katzuv commented Nov 22, 2024

#74 has no code related to alerts so I'm not sure what you expect to see.

@rakrakon
Copy link
Contributor

rakrakon commented Nov 24, 2024

Sorry, forgot to push the commit.

@katzuv
Copy link
Member

katzuv commented Nov 26, 2024

now I realize that if you want to see the alerts in AdvantageScope you probably won't see them because they aren't logged. However, they will be logged in the beta version of AdvantageKit so I would just wait for its release which should be soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants