Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marker button #74

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

Add marker button #74

wants to merge 14 commits into from

Conversation

rakrakon
Copy link
Contributor

  • Create MarkerCommands
  • Create markEvent command
  • Create markAbnormalEvent command
  • Attach button to markAbnormalEvent command
  • Add missing import

@rakrakon rakrakon requested review from katzuv and Emma03L November 11, 2024 10:49
import edu.wpi.first.wpilibj2.command.Command
import edu.wpi.first.wpilibj2.command.Commands

const val ABNORMAL_EVENT_NAME = "EVENT"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add the time since match start/match end. Did you check it's convenient in the console tab? I would also add error/warning so AdvantageScope will color it (check their docs for the exact wording).

@katzuv
Copy link
Member

katzuv commented Nov 19, 2024

Looks like you need to change the base branch

@katzuv katzuv linked an issue Nov 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add marker button for drivers
3 participants