Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable standard deviation in pose estimation code #19

Open
katzuv opened this issue Feb 10, 2024 · 2 comments
Open

Variable standard deviation in pose estimation code #19

katzuv opened this issue Feb 10, 2024 · 2 comments

Comments

@katzuv
Copy link
Member

katzuv commented Feb 10, 2024

Okay, now I understand. So why not just pass these as parameters to the constructor, similar to how we pass parameters to the swerve drive constructor?
However, this should support variable standard deviations. See here on how 6328 calculated vision standard deviations in 2023: https://www.chiefdelphi.com/t/frc-6328-mechanical-advantage-2023-build-thread/420691/157?u=dan

Originally posted by @katzuv in Galaxia5987/robot-2024#39 (comment)

It seems to me that 7f4ea7d doesn't fully address this need.

@rakrakon
Copy link
Contributor

be83eaa

@katzuv
Copy link
Member Author

katzuv commented Feb 10, 2024

I don't see how the current implementation of addVisionMeasurement() can calculate the standard deviation for the vision result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants