Simpler led functions #27
Conversation
|
Just came to say I love the term "blink-a-blink-blink" 👍 |
| rainbowHue%=180; | ||
| } | ||
| System.out.println("after loop statement"); | ||
| } | ||
| } |
There was a problem hiding this comment.
Take this with a grain of salt since it's been forever since ive worked in FRC,
but shouldn't if rainbow be checked before the Primary and Secondary colors?
In this scenario for 1 frame you will have a flickering of the leds.
Suggestion: (i forgot how to actually write it in the code:
above if(blink) (line 96 or after in line 105)
if(isRainbow) {mode = Mode.ELSE}
then you just have a simple
if(PRIMARY) {}
else if (SECONDARY) {}
else{/*ELSE*/}
There was a problem hiding this comment.
The rainbow LEDs work great so I guess if it ain't broke don't fix it
There was a problem hiding this comment.
This is a good rule to follow many times, but not always. The offseason is the best time to improve software and learn, now's the time to make such changes and improvements to the code.
This pull requests adds cool new LED functions that make them blink-a-blink-blink