Skip to content

Led subsystem

Led subsystem #290

GitHub Actions / Qodana Community for JVM completed Feb 8, 2025 in 0s

249 new problems found by Qodana Community for JVM

Qodana Community for JVM

249 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 139
Unnecessary modifier 🔶 Warning 22
Constant conditions 🔶 Warning 6
Field can be local 🔶 Warning 5
Unnecessary conversion to 'String' 🔶 Warning 5
Unused receiver parameter 🔶 Warning 4
Declaration has problems in Javadoc references 🔶 Warning 3
Unresolved reference in KDoc 🔶 Warning 3
Field may be 'final' 🔶 Warning 2
Busy wait 🔶 Warning 1
Infinite loop statement 🔶 Warning 1
Unused import directive 🔶 Warning 1
Main function should return 'Unit' 🔶 Warning 1
Mismatched read and write of array 🔶 Warning 1
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 1
Call to 'printStackTrace()' 🔶 Warning 1
Unused import 🔶 Warning 1
Class member can have 'private' visibility ◽️ Notice 23
Lambda argument inside parentheses ◽️ Notice 13
Constant values ◽️ Notice 12
Might be 'const' ◽️ Notice 2
Commented out code ◽️ Notice 1
Method can be extracted ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 126 in src/main/kotlin/frc/robot/subsystems/drive/PhoenixOdometryThread.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Busy wait

Call to `Thread.sleep()` in a loop, probably busy-waiting

Check notice on line 432 in src/main/kotlin/frc/robot/subsystems/drive/TunerConstants.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Commented out code

Commented out code (9 lines)

Check notice on line 405 in src/main/kotlin/frc/robot/subsystems/drive/TunerConstants.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values

Value `kFrontRightSteerMotorInverted` is always 'true'

Check notice on line 394 in src/main/kotlin/frc/robot/subsystems/drive/TunerConstants.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values

Value `kFrontLeftCANcoderInverted` is always 'false'

Check notice on line 416 in src/main/kotlin/frc/robot/subsystems/drive/TunerConstants.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values

Value `kInvertLeftSide` is always 'true'

Check notice on line 430 in src/main/kotlin/frc/robot/subsystems/drive/TunerConstants.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values

Value `kBackRightCANcoderInverted` is always 'false'

Check notice on line 417 in src/main/kotlin/frc/robot/subsystems/drive/TunerConstants.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values

Value `kBackLeftSteerMotorInverted` is always 'true'

Check notice on line 392 in src/main/kotlin/frc/robot/subsystems/drive/TunerConstants.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values

Value `kInvertLeftSide` is always 'true'

Check notice on line 406 in src/main/kotlin/frc/robot/subsystems/drive/TunerConstants.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values

Value `kFrontRightCANcoderInverted` is always 'false'

Check notice on line 429 in src/main/kotlin/frc/robot/subsystems/drive/TunerConstants.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values

Value `kBackRightSteerMotorInverted` is always 'true'

Check notice on line 418 in src/main/kotlin/frc/robot/subsystems/drive/TunerConstants.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values

Value `kBackLeftCANcoderInverted` is always 'false'

Check notice on line 428 in src/main/kotlin/frc/robot/subsystems/drive/TunerConstants.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values

Value `kInvertRightSide` is always 'true'

Check notice on line 393 in src/main/kotlin/frc/robot/subsystems/drive/TunerConstants.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values

Value `kFrontLeftSteerMotorInverted` is always 'true'

Check notice on line 404 in src/main/kotlin/frc/robot/subsystems/drive/TunerConstants.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values

Value `kInvertRightSide` is always 'true'

Check notice on line 278 in src/main/kotlin/frc/robot/subsystems/drive/DriveCommands.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Method can be extracted

It's possible to extract method returning 'wheelDelta' from a long surrounding method

Check warning on line 56 in src/main/kotlin/frc/robot/subsystems/drive/ModuleIOTalonFX.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field can be local

Field can be converted to a local variable

Check warning on line 28 in src/main/kotlin/frc/robot/subsystems/vision/Vision.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field can be local

Field can be converted to a local variable

Check warning on line 31 in src/main/kotlin/frc/robot/subsystems/vision/Vision.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field can be local

Field can be converted to a local variable

Check warning on line 30 in src/main/kotlin/frc/robot/subsystems/vision/VisionIOPhotonVisionSim.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field can be local

Field can be converted to a local variable

Check warning on line 29 in src/main/kotlin/frc/robot/subsystems/vision/Vision.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field can be local

Field can be converted to a local variable

Check warning on line 46 in src/main/kotlin/frc/robot/subsystems/drive/PhoenixOdometryThread.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field may be 'final'

Field `isCANFD` may be 'final'

Check warning on line 142 in src/main/kotlin/frc/robot/subsystems/drive/Drive.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field may be 'final'

Field `poseEstimator` may be 'final'

Check warning on line 116 in src/main/kotlin/frc/robot/subsystems/drive/PhoenixOdometryThread.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Infinite loop statement

`while` statement cannot complete without throwing an exception

Check warning on line 110 in src/main/kotlin/frc/robot/lib/PhoenixUtil.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Declaration has problems in Javadoc references

Cannot resolve symbol `SwerveModuleConstants`

Check warning on line 108 in src/main/kotlin/frc/robot/lib/PhoenixUtil.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Declaration has problems in Javadoc references

Cannot resolve symbol `SwerveModuleConstants`