Single source of truth for import relations #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving in the direction of having one source of truth for input predicates, rather than duplicating the list of input predicates between the fact generator and Datalog code.
This will help rewrite predicate_groups.cpp in terms of predicates.inc
These files shouldn't have any declarations nor rules in them. This will help generate these files from an include file shared with the Fact Generator.
Next step: Do the same for the import-*.dl files.
Now the FactGenerator and Datalog code have the same source of truth about relation and file names.
langston-barrett
force-pushed
the
lb/predicates-include
branch
from
c4ebcca to
0715645
Compare
No longer needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37
Still needs:
import-*.dlfrom includestodo.dl