ci, docker: Disaggregate Clang and LLVM versions, Clang 11, LLVM 10+11 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langston-barrett
changed the title
langston-barrett
force-pushed
the
lb/clang11
branch
from
6b19229
to
5af10f7
Compare
langston-barrett
changed the title
langston-barrett
force-pushed
the
lb/clang11
branch
3 times, most recently
from
6f5b3c3
to
a851236
Compare
langston-barrett
changed the title
|
Oh whoops, the dev container needs a version of Clang that is no newer than the version of LLVM, since it compiles the C programs in the test suite... Or we could check in the LLVM IR files... |
|
I think the right answer is to limit the version of Clang to that of the highest supported version of LLVM, and only run the golden tests when using the highest supported versions. That way, we keep just one copy of the golden tests and save on CI minutes. |
langston-barrett
changed the title
|
Well, after updating the golden tests for Clang+LLVM 11, there are a lot of changes... Will have to go through those manually to see if they're reasonable... |
langston-barrett
force-pushed
the
lb/clang11
branch
from
96c2d3c
to
e71656a
Compare
....-g-grecord-gcc-switches-O1-O0-fno-discard-value-names.1-callsite.allocation_size.golden.csv
Outdated
Show resolved
Hide resolved
...switches-O1-O1-fno-discard-value-names.1-callsite.subset.callgraph.callgraph_edge.golden.csv
Show resolved
Hide resolved
...switches-O1-O1-fno-discard-value-names.1-callsite.subset.callgraph.callgraph_edge.golden.csv
Show resolved
Hide resolved
...switches-O1-O1-fno-discard-value-names.1-callsite.subset.callgraph.callgraph_edge.golden.csv
Show resolved
Hide resolved
...rd-gcc-switches-O1-O1-fno-discard-value-names.1-callsite.subset.operand_points_to.golden.csv
Show resolved
Hide resolved
....-g-grecord-gcc-switches-O1-O0-fno-discard-value-names.1-callsite.allocation_size.golden.csv
Show resolved
Hide resolved
...switches-O1-O1-fno-discard-value-names.1-callsite.subset.callgraph.callgraph_edge.golden.csv
Show resolved
Hide resolved
langston-barrett
added a commit
that referenced
this pull request
Oct 25, 2022
This demonstrates a bug: These globals should have known size, but they don't. See discussion on #93.
langston-barrett
added a commit
that referenced
this pull request
Oct 25, 2022
This demonstrates a bug: These globals should have known size, but they don't. See discussion on #93.
Bump Clang version in next commit
That's the highest available for Focal in this PPA.
langston-barrett
force-pushed
the
lb/clang11
branch
from
fb764e4
to
a4a45f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #12