Skip to content

Commit

Permalink
CI: Disambiguate Windows MSI installer name
Browse files Browse the repository at this point in the history
Previously, this Windows MSI installer was lumped into the same artifact name
as the general Windows binary distribution (e.g.,
`cryptol-3.2.0.99-windows-2019-X64 (GHC 9.4.8)`). As of `v4` of GitHub Actions'
`upload-artifact`, however, it is an error to have two separate
`upload-artifact` steps share the same artifact name. As such, we have to
disambiguate the Windows installer artifact, which this patch accomplishes.
  • Loading branch information
RyanGlScott committed Sep 3, 2024
1 parent 6d2fa0e commit 59c7e4f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ jobs:
- uses: actions/upload-artifact@v4
if: runner.os == 'Windows'
with:
name: ${{ env.NAME }} (GHC ${{ matrix.ghc-version }})
name: Windows MSI installer (GHC ${{ matrix.ghc-version }})
path: "cryptol.msi*"
if-no-files-found: error
retention-days: ${{ needs.config.outputs.retention-days }}
Expand Down

0 comments on commit 59c7e4f

Please sign in to comment.