Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: receive screen #2442

Closed
wants to merge 29 commits into from
Closed

refactor: receive screen #2442

wants to merge 29 commits into from

Conversation

sandipndev
Copy link
Member

@sandipndev sandipndev commented Jun 29, 2023 •
edited
Loading

The objective of this PR is to make the receive screen much better and in line with how things are dealt with in the send flow.

Todos

  • Delete individual receive usd and bitcoin screens
  • Refactor Payment Request and usePaymentRequest hook to be more in line with send
  • Add three new pills - Invoice, On-chain and Paycode
  • Let users pick between Bitcoin and USD (preselect default wallet) for LN Invoice
  • Amountless or Invoice with Amount
  • Add Note
  • (when screenshot in LN Invoice) Display text: This invoice is only one time use and expires in 24 hours.

@nicolasburtey

This comment was marked as resolved.

Sign in to view
@UncleSamtoshi
Copy link
Contributor

Refactor Payment Request and usePaymentRequest hook to be more in line with send

Curious what you were thinking of changing with this as it was recently refactored. Would love to talk about the design of it before you make any changes.

@sandipndev
refactor: trying to combine both receive screens - deleted individuals
853c018
@sandipndev
feat: button group
4ac6eaf
@sandipndev
feat: receive ways
4f81b05
@sandipndev
fix: styleS
6433358
@sandipndev
save, doesn't compile but has the simpler payment request
5d23382
@sandipndev
chore: dont use constriants ts now
bb7d81d
@sandipndev
feat: payment request
7017f55
@sandipndev
feat: payment quotation
7a2ab6b
@sandipndev
feat: expiresIn and sets
bd3d3be
@sandipndev
feat: feesInfo and detect paid
b10373b
@sandipndev
feat: qr view
4374ab1
@sandipndev
refactor: rename payment-request and payment-request-creation-data
7f4d6b3
@sandipndev
feat: screen initial looks good
7bc623d
@sandipndev
feat: amount and note working
caf49ff
@sandipndev
feat: note input separate and expires in info
1c5f020
@sandipndev
feat: added copy and share invoice
ffaf2d4
@sandipndev
feat: paycode also working
a4ea64f
@sandipndev
feat: paycode await
d969844
@sandipndev
feat: regenerate invoice
aeb73e3
@sandipndev
feat: animate qr code and copy on tap
9c3816e
@sandipndev
feat: paycode username modal
307a49a
@sandipndev
feat: onchain receive fees
f82890a
@sandipndev
feat: small nit picks
1f7a2b7
@sandipndev
feat: more nit picks
890fc7e
@sandipndev
feat: more language stiff
112f079
@sandipndev sandipndev closed this Jul 14, 2023
@sandipndev sandipndev deleted the refactor--receive-screen branch July 14, 2023 09:29
@sandipndev sandipndev restored the refactor--receive-screen branch July 14, 2023 09:29
@sandipndev sandipndev mentioned this pull request Jul 15, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasburtey nicolasburtey nicolasburtey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandipndev @nicolasburtey @UncleSamtoshi