Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RNSecureKeyStore for auth token persistent storage #3122

Open
wants to merge 48 commits into
base: main
Choose a base branch
from

Merge branch 'main' into 848-use-react-native-keychain

c46b065
Select commit
Loading
Failed to load commit list.
Open

Use RNSecureKeyStore for auth token persistent storage #3122

Merge branch 'main' into 848-use-react-native-keychain
c46b065
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks completed Apr 25, 2024 in 38s

4 secrets uncovered!

4 secrets were uncovered from the scan of 48 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #3122: 848-use-react-native-keychain 👉 main
GitGuardian id GitGuardian status Secret Commit Filename
- Generic High Entropy Secret 06c91ed dev/vendor/galoy-quickstart/dev/core-bundle/integration-env.json View secret
- Generic High Entropy Secret 06c91ed dev/vendor/galoy-quickstart/dev/core-bundle/serve-env.json View secret
- Generic High Entropy Secret 06c91ed dev/vendor/galoy-quickstart/dev/Tiltfile View secret
- Generic Private Key 06c91ed dev/vendor/galoy-quickstart/dev/config/notifications/fake_service_account.json View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!