feat: store multiple tokens #3272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prakhar-Agarwal-byte
force-pushed
the
store_multi_tokens
branch
from
bfff952 to
fd853da
Compare
|
@Prakhar-Agarwal-byte unit tests are failing, it expects the new schema. Can you fix that? |
sandipndev
reviewed
May 17, 2024
|
I think this PR should also be merged first: #3122 Before we think of multiple token, we need to make storing tokens safer |
Signed-off-by: Prakhar Agarwal <[email protected]>
Signed-off-by: Prakhar Agarwal <[email protected]>
Prakhar-Agarwal-byte
force-pushed
the
store_multi_tokens
branch
from
9b3dbd7 to
6f2d81b
Compare
sandipndev
reviewed
Jun 15, 2024
…m schema 6 to 7 Signed-off-by: Prakhar Agarwal <[email protected]>
Prakhar-Agarwal-byte
force-pushed
the
store_multi_tokens
branch
from
fdef85f to
2e7f7ea
Compare
|
I will do a thorough testing on logged in phones / non logged in phones and verify the user is not logged out before merging. |
|
Verified and merged! |
sandipndev
pushed a commit
to Prakhar-Agarwal-byte/galoy-mobile
that referenced
this pull request
Jul 30, 2024
* feat: store multiple tokens Signed-off-by: Prakhar Agarwal <[email protected]> * fix: update persistent state property names, update test Signed-off-by: Prakhar Agarwal <[email protected]> * fix: current token should be present in all tokens when migrating from schema 6 to 7 Signed-off-by: Prakhar Agarwal <[email protected]> --------- Signed-off-by: Prakhar Agarwal <[email protected]>
dolcalmi
pushed a commit
that referenced
this pull request
Nov 5, 2024
* feat: store multiple tokens Signed-off-by: Prakhar Agarwal <[email protected]> * fix: update persistent state property names, update test Signed-off-by: Prakhar Agarwal <[email protected]> * fix: current token should be present in all tokens when migrating from schema 6 to 7 Signed-off-by: Prakhar Agarwal <[email protected]> --------- Signed-off-by: Prakhar Agarwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Token management for #3273