chore: do not return error on InvalidMobileCountryCodeForPhoneMetadat…

…aError
GaloyMoney · Dec 7, 2023 · 0785224 · 0785224
1 parent c7d448c
commit 0785224
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/core/api/src/domain/users/index.types.d.ts b/core/api/src/domain/users/index.types.d.ts
@@ -22,8 +22,8 @@ type ChannelType =
 type PhoneMetadata = {
   // from twilio
   carrier: {
-    error_code: string // check this is the right syntax
-    mobile_country_code: string
+    error_code: string | null
+    mobile_country_code: string | null
     mobile_network_code: string | null
     name: string | null
     type: CarrierType | null

diff --git a/core/api/src/domain/users/phone-metadata-validator.ts b/core/api/src/domain/users/phone-metadata-validator.ts
@@ -1,3 +1,4 @@
+import { recordExceptionInCurrentSpan } from "@/services/tracing"
 import {
   InvalidCarrierForPhoneMetadataError,
   InvalidCarrierTypeForPhoneMetadataError,
@@ -7,6 +8,7 @@ import {
 } from "./errors"
 
 import { CarrierType } from "@/domain/phone-provider"
+import { ErrorLevel } from "../shared"
 
 const checkedToCarrierType = (
   rawCarrierType: string | undefined | null,
@@ -47,7 +49,10 @@ export const PhoneMetadataValidator = (): PhoneMetadataValidator => {
     }
 
     if (typeof mobile_country_code !== "string") {
-      return new InvalidMobileCountryCodeForPhoneMetadataError(mobile_country_code)
+      recordExceptionInCurrentSpan({
+        error: new InvalidMobileCountryCodeForPhoneMetadataError(mobile_country_code),
+        level: ErrorLevel.Critical,
+      })
     }
 
     if (typeof countryCode !== "string") {