build: add 'override_env' dict option to dev_pnpm_task_binary

GaloyMoney · Jan 8, 2024 · 55d67d1 · 55d67d1
1 parent 7253750
commit 55d67d1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/core/api/BUCK b/core/api/BUCK
@@ -276,6 +276,9 @@ dev_pnpm_task_binary(
   srcs = [":src"],
   visibility = ["PUBLIC"],
   env = dummy_env_dict,
+  override_env = {
+    "MONGODB_CON": "mongodb://localhost:27017/galoy",
+  },
 )
 
 dev_pnpm_task_binary(

diff --git a/toolchains/workspace-pnpm/macros.bzl b/toolchains/workspace-pnpm/macros.bzl
@@ -1042,7 +1042,9 @@ def dict_to_env_string(input_dict):
     return '\n'.join(env_strings)
 
 def pnpm_task_binary_impl(ctx: AnalysisContext) -> list[[DefaultInfo, RunInfo]]:
-    env_file = ctx.actions.write(".env", dict_to_env_string(ctx.attrs.env), is_executable = True)
+    combined_env = dict(ctx.attrs.env)
+    combined_env.update(ctx.attrs.override_env)
+    env_file = ctx.actions.write(".env", dict_to_env_string(combined_env), is_executable = True)
 
     script = ctx.actions.write("pnpm-run.sh", """\
 #!/usr/bin/env bash
@@ -1092,6 +1094,13 @@ dev_pnpm_task_binary = rule(impl = pnpm_task_binary_impl, attrs = {
         default = {},
         doc = """Env values to inject for pnpm command run"""
     ),
+    "override_env": attrs.dict(
+        key = attrs.string(),
+        value = attrs.arg(),
+        sorted = False,
+        default = {},
+        doc = """Env values to override originally injected values with"""
+    ),
 })
 
 def pnpm_task_test_impl(ctx: AnalysisContext) -> list[[DefaultInfo, ExternalRunnerTestInfo]]: