chore: make processingCompleted non-optional

GaloyMoney · Nov 17, 2023 · 7e14b14 · 7e14b14
1 parent 40b4a5e
commit 7e14b14
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/core/api/src/domain/wallet-invoices/index.types.d.ts b/core/api/src/domain/wallet-invoices/index.types.d.ts
@@ -93,7 +93,7 @@ type WalletInvoiceWithOptionalLnInvoice = {
   recipientWalletDescriptor: PartialWalletDescriptor<WalletCurrency>
   paid: boolean
   createdAt: Date
-  processingCompleted?: boolean
+  processingCompleted: boolean
   lnInvoice?: LnInvoice // LnInvoice is optional because some older invoices don't have it
 }
 

diff --git a/core/api/src/services/mongoose/schema.types.d.ts b/core/api/src/services/mongoose/schema.types.d.ts
@@ -69,7 +69,7 @@ interface WalletInvoiceRecord {
   currency: string
   timestamp: Date
   selfGenerated: boolean
-  processingCompleted?: boolean
+  processingCompleted: boolean
   pubkey: string
   paid: boolean
   paymentRequest?: string // optional because we historically did not store it

diff --git a/core/api/src/services/mongoose/wallet-invoices.ts b/core/api/src/services/mongoose/wallet-invoices.ts
@@ -120,10 +120,7 @@ export const WalletInvoicesRepository = (): IWalletInvoicesRepository => {
     try {
       pending = WalletInvoice.find({
         paid: false,
-        $or: [
-          { processingCompleted: false },
-          { processingCompleted: { $exists: false } }, // TODO remove this after migration
-        ],
+        processingCompleted: false,
       }).cursor({
         batchSize: 100,
       })