Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: return batchInclusionEstimatedAt from sendOnChain #3626

Merged
merged 3 commits into from
Dec 5, 2023
Merged

chore: return batchInclusionEstimatedAt from sendOnChain #3626

merged 3 commits into from
Dec 5, 2023

Conversation

bodymindarts
Copy link
Member

No description provided.

@github-actions github-actions bot added the core label Nov 29, 2023
@dolcalmi
Copy link
Collaborator

dolcalmi commented Nov 29, 2023 •
edited
Loading

I think is better to include this after #3619 because it also requires to update transaction in graphql, i.e, is not necessary in app layer unless is part of wallet transaction

@bodymindarts bodymindarts merged commit b72569e into main Dec 5, 2023
15 checks passed
@sandipndev sandipndev deleted the batch-inclusion branch December 6, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolcalmi dolcalmi Awaiting requested review from dolcalmi

@vindard vindard Awaiting requested review from vindard

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bodymindarts @dolcalmi