refactor(notifications): move device token to notifications #3891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodymindarts
force-pushed
the
move-device-token-to-notifications
branch
from
653a4ce to
10916e0
Compare
UncleSamtoshi
force-pushed
the
move-device-token-to-notifications
branch
from
e526e9e to
ac3d74b
Compare
| @@ -671,7 +680,7 @@ describe("onChainPay", () => { | |||
| }) | |||
|
|
|||
| // Expect sent notification | |||
| expect(sendFilteredNotification.mock.calls.length).toBe(1) | |||
| expect(sendFilteredNotification.mock.calls.length).toBe(2) | |||
There was a problem hiding this comment.
can you please explain why we needed to change an assert here @UncleSamtoshi
thevaibhav-dixit
approved these changes
Jan 24, 2024
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.