chore(core): refactor merchant data structure #3906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasburtey
force-pushed
the
chore(core)--refactor-merchant-data-structure
branch
5 times, most recently
from
0f34c14 to
a9c7c52
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nicolasburtey
force-pushed
the
chore(core)--refactor-merchant-data-structure
branch
3 times, most recently
from
b3f5a10 to
266f77c
Compare
chore: remove redundant describe test: first integration test for add merchant chore: add migration (untested yet)
nicolasburtey
force-pushed
the
chore(core)--refactor-merchant-data-structure
branch
from
266f77c to
d275287
Compare
|
when approved I will do a small iteration on the admin panel |
nicolasburtey
commented
Feb 1, 2024
| return merchants | ||
| } | ||
|
|
||
| // TODO: manage multiple merchants for a single username |
There was a problem hiding this comment.
will be done on follow up PRs, right now it's mostly a refactor
vindard
reviewed
Feb 1, 2024
core/api/src/graphql/admin/root/mutation/business-update-map-info.ts
Outdated
Show resolved
Hide resolved
| id, | ||
| }: { | ||
| id: MerchantId | ||
| }): Promise<void | ApplicationError> => { |
There was a problem hiding this comment.
In these sorts of cases we usually return true instead of void so that we don't miss any accidental early returns
Suggested change
| }): Promise<void | ApplicationError> => { | |
| }): Promise<true | ApplicationError> => { |
There was a problem hiding this comment.
that's a good point
There was a problem hiding this comment.
seems there are other place in the codebase that have Promise<void
| return | ||
| } | ||
|
|
||
| export const deleteMerchantByUsername = async ({ |
There was a problem hiding this comment.
Small nit, consistent naming
Suggested change
| export const deleteMerchantByUsername = async ({ | |
| export const deleteMerchantLocationsByUsername = async ({ |
There was a problem hiding this comment.
I'd prefer to keep it deleteMerchantByUsername for now because there is no dis-association as of now between a merchant and a location
vindard
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving the title/coordinate out of Account and into its own collection.
This is - in follow up PR - enables: