test: add bats test for map #3923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vindard
reviewed
Jan 31, 2024
bats/core/api/merchant.bats
Outdated
| HYDRA_ADMIN_API="http://localhost:4445" | ||
|
|
||
|
|
||
| @test "admin: can retrieve admin token" { |
There was a problem hiding this comment.
We already have a test for this so it can probably just be part of the setup_file or abstracted as a function
There was a problem hiding this comment.
yup I just copy and paste it. which option do you think is better? between moving to setup_file but where the code would be a test elsewhere (would be more obvious if something break), or having both place where this code run as part of a setup (less code duplicate, not obvious this is a test)?
There was a problem hiding this comment.
I think we can maybe treat it similar to how we have login_user in user.bash. Would mean not having an explicit test and simply having a function that has assertions within it
nicolasburtey
force-pushed
the
test--add-bats-test-for-map
branch
from
25b82d3 to
4256837
Compare
vindard
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.