feat(map): initialising map #3938
Conversation
siddhart1o1
changed the title
siddhart1o1
force-pushed
the
feat--initialising--blink-map
branch
from
dc38a16 to
5a99f27
Compare
| zoomControl: true, | ||
| maxZoom: 38, | ||
| minZoom: 3, | ||
| styles: [...theme, ...unwantedMarkers], |
There was a problem hiding this comment.
what does unwantedMarkets means? why is it useful?
There was a problem hiding this comment.
Remove unnecessary noise/markers from maps. Otherwise, there is too much information on the map.
There was a problem hiding this comment.
But where do those markers come from?
There was a problem hiding this comment.
Assuming it comes from Google maps api, it seems Google maps charge for every single piece of information requested. So if we have to turn all that off, I would think there might be a way to not ask those informations in the first place, which would limit our billing
There was a problem hiding this comment.
Assuming it comes from Google maps api, it seems Google maps charge for every single piece of information requested. So if we have to turn all that off, I would think there might be a way to not ask those informations in the first place, which would limit our billing
Map charges are based on the number of loads; hiding or displaying marker information does not affect it.
https://mapsplatform.google.com/pricing/
There was a problem hiding this comment.
ok I don't really understand the detail but I think that is fine. We should ensure that the API key we created is protected by a browser referrer or something like that to ensure it's not used abusely; this is how we could ends up with a large bill, probably like the experience Lee had.
|
the "center me" appears to be totally off on my computer (I didn't approve the request when asked to see how that would react... so I would assume it should be a no-op in that case, but it still zoom in in a "random" point in the middle of El Salvador) |
Yes, I know. I was working on it; it's fixed now. Now, the pointer will only be shown if the user allows their location. |
siddhart1o1
force-pushed
the
feat--initialising--blink-map
branch
from
e0a6a40 to
efef738
Compare
rebase rebase
rebase
rebase
siddhart1o1
force-pushed
the
feat--initialising--blink-map
branch
from
ab67f41 to
cfff024
Compare
No description provided.