Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-organize tilt file #3967

Closed
wants to merge 7 commits into from
Closed

chore: re-organize tilt file #3967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
69a03bc
build: re-order Tiltfile
vindard Feb 9, 2024
21a12cb
fix: change back integration upload action to always
vindard Feb 9, 2024
f43487a
fix: adjust readiness_probe's in Tiltfile
vindard Feb 9, 2024
4697a2c
ci: add readiness_probe to consent
vindard Feb 9, 2024
b5971d3
ci: add readiness_probe to other apps
vindard Feb 9, 2024
e9cdb21
build: add price-history-pg healthcheck
vindard Feb 9, 2024
4e2c1ff
build: add separate build args for check action
vindard Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/check-code-and-unit-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
id: prepare_args
run: |
ARGS=""
BUILD_ARGS=""

cat <<EOF > labels.json
${{ toJSON(github.event.pull_request.labels.*.name) }}
Expand All @@ -40,21 +41,26 @@ jobs:
case "$LABEL" in
dashboard|consent|pay|admin-panel|map)
ARGS+=" //apps/$LABEL:test"
BUILD_ARGS+=" //apps/$LABEL:node_modules"
;;
core)
ARGS+=" //core/api:test"
BUILD_ARGS+=" //core/api:prod_build"
;;
api-keys|notifications)
ARGS+=" //core/$LABEL:$LABEL"
BUILD_ARGS+=" //core/$LABEL:$LABEL"
;;
esac
done

echo "Prepared args: $ARGS"
echo "Prepared build_args: $BUILD_ARGS"
echo "args=$ARGS" >> "$GITHUB_OUTPUT"
echo "build_args=$BUILD_ARGS" >> "$GITHUB_OUTPUT"
- name: Build via buck2
if: steps.prepare_args.outputs.args != ''
run: nix develop -c buck2 build ${{ steps.prepare_args.outputs.args }}
run: nix develop -c buck2 build ${{ steps.prepare_args.outputs.build_args }}
- name: Run checks and tests via buck2
if: steps.prepare_args.outputs.args != ''
run: nix develop -c buck2 test ${{ steps.prepare_args.outputs.args }}
5 changes: 2 additions & 3 deletions .github/workflows/integration-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,13 @@ jobs:
echo "Prepared args: $ARGS"
echo "args=$ARGS" >> "$GITHUB_OUTPUT"
- name: Build/start deps and run tests via tilt
id: tilt_test
if: steps.prepare_args.outputs.args != ''
run: nix develop -c xvfb-run ./dev/bin/tilt-ci.sh ${{ steps.prepare_args.outputs.args }}
- name: Rename Tilt log
if: steps.tilt_test.outcome == 'success' || steps.tilt_test.outcome == 'failure'
if: always()
run: mv dev/.e2e-tilt.log dev/e2e-tilt.log
- name: Upload Tilt log
if: steps.tilt_test.outcome == 'success' || steps.tilt_test.outcome == 'failure'
if: always()
uses: actions/upload-artifact@v2
with:
name: Tilt log
Expand Down
Loading
Loading