fix(notification): use serde_json in flattened structs #3981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodymindarts
force-pushed
the
async-notification-execution
branch
from
7dcf0fd to
a1ad5bb
Compare
bodymindarts
commented
Feb 12, 2024
| let data = serde_json::to_string(&raw).unwrap(); | ||
| let job_data: JobData<SendPushNotificationData> = serde_json::from_str(&data).unwrap(); | ||
| assert!(job_data.data.is_some()); | ||
| assert_eq!(job_data.tracing_data.len(), 3); |
There was a problem hiding this comment.
assert_eq!(job_data.tracing_data.len(), 3); asserting 3 because data is also present here.
thevaibhav-dixit
approved these changes
Feb 12, 2024
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.