fix(notifications): remove device tokens when bad request response #3991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let res = self.fcm.send(&device_token, &msg, event.deep_link()).await; | ||
| if let Err(e) = res { | ||
| match e { | ||
| FcmError::GoogleFcm1Error(google_fcm1::Error::BadRequest(_)) => { |
There was a problem hiding this comment.
Are we sure every BadRequest is due to the token?
There was a problem hiding this comment.
I feel we should report the error in the span as an event to know what happened
There was a problem hiding this comment.
This is what the errors so far indicate. the underlying library google_fcm1 does not have any explicit error for when registration tokens are unregistered. The error enum contains BadRequest(Value)
There was a problem hiding this comment.
For now I've added tracing so we can investigate
bodymindarts
force-pushed
the
cond-remove-tokens
branch
from
e19429f to
5660eb1
Compare
bodymindarts
force-pushed
the
cond-remove-tokens
branch
from
5660eb1 to
5cc84a9
Compare
bodymindarts
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.