Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: separate build_context rule #3999

Closed
wants to merge 5 commits into from
Closed

Conversation

vindard
Copy link
Contributor

@vindard vindard commented Feb 14, 2024

Description

This PR separates the prepare_build_context function into its own rule so that it can optionally be executed outside of its downstream tasks. This is useful for example in the Check Code and Unit Test github action to properly separate build and test run stages.

To compare test performance:

@vindard vindard marked this pull request as draft February 14, 2024 17:27
@vindard vindard changed the title build: separate build context rule build: separate build_context rule Feb 14, 2024
@vindard vindard force-pushed the separate-build-context-rule branch from 36bd0b0 to e461e5a Compare February 14, 2024 17:36
@vindard vindard removed the core label Feb 14, 2024
@vindard vindard force-pushed the separate-build-context-rule branch from e461e5a to ca0c067 Compare February 14, 2024 19:38
@github-actions github-actions bot added the core label Feb 14, 2024
@vindard vindard force-pushed the separate-build-context-rule branch from ca0c067 to 3dd5357 Compare February 14, 2024 19:44
@vindard vindard marked this pull request as ready for review February 14, 2024 19:59
@vindard vindard requested a review from bodymindarts February 14, 2024 21:47
@vindard vindard force-pushed the separate-build-context-rule branch from 4797995 to cba8b22 Compare February 15, 2024 02:21
@vindard
Copy link
Contributor Author

vindard commented Feb 15, 2024

We decided that prepare_build_context isn't actually a build step and is more a "hermetic environment prep" step that can be used before either build or executing things (like tests). Based on that, this PR will be closed in favour of another PR that simply renames the function to reflect this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant