feat(notifications): add email client #4002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thevaibhav-dixit
force-pushed
the
email-executor
branch
from
b4a89c7 to
8523e10
Compare
|
Rebasing to this PR once it's merged should help with the integration failure |
thevaibhav-dixit
force-pushed
the
email-executor
branch
6 times, most recently
from
1a00d71 to
9cc2422
Compare
| pub fn init(config: SmtpConfig) -> Result<Self, SmtpError> { | ||
| let creds = Credentials::new(config.username, config.password); | ||
| let client: AsyncSmtpTransport<Tokio1Executor> = | ||
| AsyncSmtpTransport::<Tokio1Executor>::starttls_relay("smtp.gmail.com")? |
There was a problem hiding this comment.
Why is this endpoint hard coded?
There was a problem hiding this comment.
was just for testing should come in via the config.
|
|
||
| pub async fn send_email(&self, msg: LocalizedMessage) -> Result<(), SmtpError> { | ||
| let email = Message::builder() | ||
| .from(Mailbox::new(None, "some-email".parse()?)) |
There was a problem hiding this comment.
from / to also needs setting right?
thevaibhav-dixit
force-pushed
the
email-executor
branch
2 times, most recently
from
923bda0 to
8466b93
Compare
core/notifications/src/app/config.rs
Outdated
| @@ -1,8 +1,9 @@ | |||
| use serde::{Deserialize, Serialize}; | |||
|
|
|||
| use crate::push_executor::PushExecutorConfig; | |||
| use crate::{email_executor::EmailExecutorConfig, push_executor::PushExecutorConfig}; | |||
|
|
|||
| #[derive(Clone, Default, Serialize, Deserialize)] | |||
| pub struct AppConfig { | |||
| pub executor: PushExecutorConfig, | |||
There was a problem hiding this comment.
Note: rename this to push_executor
thevaibhav-dixit
force-pushed
the
email-executor
branch
3 times, most recently
from
0d581ba to
b9016bb
Compare
UncleSamtoshi
force-pushed
the
email-executor
branch
from
08b4c26 to
5cc1373
Compare
bodymindarts
approved these changes
Feb 20, 2024
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.