refactor(core): clean up pending invoice "finally" handling #4015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vindard
force-pushed
the
refactor-pending-invoice
branch
5 times, most recently
from
bc0175c to
d0a5b4a
Compare
This is to introduce the new type and use it to decide when to mark invoices as 'proceesing completed' and 'paid'. The existing logic is kept in place an no iteration has been done on that as yet here. That will be addressed in follow-up commits.
vindard
force-pushed
the
refactor-pending-invoice
branch
from
d0a5b4a to
b4dff9a
Compare
bodymindarts
approved these changes
Feb 19, 2024
This was referenced Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an in-place refactor of the "update pending invoice" related functions where a new more expressive return type is introduced but the existing functionality is kept exactly in place.
After this PR, things to do: