refactor(core): clean pending invoice 'markAsPaid' signals #4028
Conversation
vindard
force-pushed
the
refactor-pending-invoice
branch
3 times, most recently
from
8d020de to
1986270
Compare
vindard
force-pushed
the
refactor-pending-invoice
branch
from
a08a638 to
5138f46
Compare
| return ProcessPendingInvoiceResult.err(lndService) | ||
| } | ||
| // Returns 'true' on re-runs if invoice is already settled in lnd |
There was a problem hiding this comment.
I think if the invoice is already settled we need to early return right?
The way I currently read the code it is possible for 339 const journal = await LedgerFacade.recordReceiveOffChain({ to be executed more than once.
There was a problem hiding this comment.
We do higher up I believe, but I just noticed that it's a paid check and not a processingCompleted check. Fixed here 52b1db1
| @@ -173,7 +183,7 @@ const processPendingInvoice = async ({ | |||
| currency: WalletCurrency.Btc, | |||
| }) | |||
| if (receivedBtc instanceof Error) { | |||
| return ProcessPendingInvoiceResult.paidWithError(receivedBtc) | |||
| return ProcessPendingInvoiceResult.processAsPaidWithError(receivedBtc) | |||
There was a problem hiding this comment.
if we have a conversion error it should be marked as paid/processed or just error?
There was a problem hiding this comment.
True, this is the same kind of error as the checkedToSats one just above it, a validation error from an invalid amount passed. I made a change to treat them both the same and to decline the invoice if an invalid amount somehow comes through the process cdcfcd7
In theory this specific check will only fail if the amount passed in is a non-integer value, which should never really happen.
…pired' are mutually exclusive
vindard
force-pushed
the
refactor-pending-invoice
branch
from
cdcfcd7 to
ee294b7
Compare
Description
This is a refactor to clean up and clarify when we mark transactions as "processed" or "paid and processed" depending on the outcome of the "update pending invoices" function.
This was prompted by issues observed where invoices would sometimes be wrongly marked as paid.