Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(notifications): add email port #4035

Merged
merged 1 commit into from
Feb 20, 2024
Merged

chore(notifications): add email port #4035

merged 1 commit into from
Feb 20, 2024

Conversation

thevaibhav-dixit
Copy link
Contributor

No description provided.

@@ -7,4 +7,5 @@ pub struct SmtpConfig {
pub password: String,
pub from_email: String,
pub relay: String,
pub port: u16,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not default it here?

@@ -14,5 +14,6 @@ app:
username: ""
from_email: ""
relay: ""
port: 587
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should actually all be commented... its just for documentation

@bodymindarts bodymindarts merged commit 1af8f5d into main Feb 20, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants