fix: assistant function call when multple tool are needed in the same… #4483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolcalmi
reviewed
May 20, 2024
| const query = JSON.parse(args).query_str | ||
| for (const toolCall of action.submit_tool_outputs.tool_calls) { | ||
| const name = toolCall.function.name | ||
| assert(name === "queryBlinkKnowledgeBase") |
There was a problem hiding this comment.
not a blocker but this is not a standard way to throw an exception. if we want to use it please catch properly AssertionError in the catch block
dolcalmi
reviewed
May 20, 2024
| } | ||
|
|
||
| return true | ||
| } else { | ||
| return new UnknownChatAssistantError("issue running the assistant") | ||
| return new UnknownChatAssistantError("Issue running the assistant") |
There was a problem hiding this comment.
else block is not necessary
dolcalmi
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… query