Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(voucher): better accuracy for exchange rate #4501

Merged
merged 1 commit into from
Jun 5, 2024
Merged

chore(voucher): better accuracy for exchange rate #4501

merged 1 commit into from
Jun 5, 2024

Conversation

siddhart1o1
Copy link
Member

  • Cent amounts returned by the API are integers; therefore, using a larger amount improves accuracy. Specially for weaker currencies.

@siddhart1o1 siddhart1o1 enabled auto-merge (squash) June 5, 2024 16:50
@siddhart1o1 siddhart1o1 requested a review from nicolasburtey June 5, 2024 17:00
@siddhart1o1 siddhart1o1 merged commit 0091351 into main Jun 5, 2024
12 of 16 checks passed
@galoybot-app galoybot-app bot mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasburtey nicolasburtey nicolasburtey approved these changes

Assignees
No one assigned
Labels
voucher
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddhart1o1 @nicolasburtey