New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): avoid logout before initiate totp #4606

Merged

dolcalmi merged 1 commit into main from fix-totp-registration-race-condition

Oct 5, 2024

Collaborator

dolcalmi commented Oct 5, 2024 •

edited

Loading

Fix https://ui.honeycomb.io/galoy/datasets/galoy-bbw/result/C1KR8g2dQJQ?hideCompare

if kratosInitiateTotp fail user should not be logged out
avoid race condition when session is logged out before being able to initiate totp registration

github-actions bot added the core label


          fix(core): avoid logout before initiate totp

3b20f81

dolcalmi force-pushed the fix-totp-registration-race-condition branch from 5ed1b90 to 3b20f81 Compare

October 5, 2024 01:15

jireva approved these changes

View reviewed changes

dolcalmi merged commit 0c3a603 into main

10 checks passed

galoybot-app bot mentioned this pull request

chore(deps): bump-core-bundle-images-0c3a603 GaloyMoney/charts#7122

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core