fix: admin oathkeeper request fwd #4397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krtk6160
force-pushed
the
chore--hacky-fix-for-oathkeeper-admin-rule
branch
from
3cce304 to
a4e4175
Compare
krtk6160
force-pushed
the
chore--hacky-fix-for-oathkeeper-admin-rule
branch
from
a4e4175 to
1d5f024
Compare
nicolasburtey
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hacky fix for forwarding the requests made to the admin ingress to the correct path on the decisions api endpoint. Because oathkeeper uses cues from the nginx headers that we set via the auth-snippet annotation, it sends the requests to the /graphql path on the decisions api - which then gets matched against the public api rules.